Conversation
|
|
||
| <Callout type="warning"> | ||
| For fully shielded osmosis swaps (from shieleded address to shielded address), | ||
| the operator should refrain from charging a fee. |
There was a problem hiding this comment.
why should the operator refrain from charging a fee? I think a small justification is worthwhile here.
| where the first element of the tuple is the receiver of the fee (an address | ||
| controlled by the operator) and the second one is the fee expressed as a | ||
| percentage of the shielded/unshielded amount. This percentage will be charged on | ||
| top of the amount specified by the user. |
There was a problem hiding this comment.
Can you write some more details about what the operator can expect to happen each time a user transacts with the MASP? For example, will an extra tx be generated and asked to be signed that pays fees?
| For transactions that move assets into or out of the shielded pool, the namada | ||
| SDK provides the possibility to charge an optional fee to support the operations | ||
| of the frontend provider. The specific transactions are: | ||
|
|
||
| - `TxShieldingTransfer` | ||
| - `TxUnshieldingTransfer` | ||
| - `TxOsmosisSwap` | ||
| - `TxIbcTransfer` | ||
| - `GenIbcShieldingTransfer` |
There was a problem hiding this comment.
can you provide some more detail on the general flow? Are operators expected to build their own instance of Namadillo on top of some release that makes certain SDK additions? Sorry I kinda have no idea myself. I think there should be more detail on how to integrate the SDK changes into one's own hosted Namada (or let me know if this is obvious and I'm just clueless)
There was a problem hiding this comment.
These are instructions for the users of the SDK, so our interface team building Namadillo or other teams building alternatives to it. For operators of Namadillo these are not the right docs and I can't help with them as I don't know how this feature has been integrated into it
brentstone
left a comment
There was a problem hiding this comment.
Mind providing some more detail here in general? See specific comments and questions
Adds documentation on how to use masp frontend sustainability fees from the SDK (based on https://github.com/namada-net/namada/pull/4790/files)